Make On*Removed conventions run even if the declaring type was removed previously #29042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
reviewed
Sep 10, 2022
|
|
||
| /// <inheritdoc /> | ||
| public virtual void ProcessKeyRemoved( | ||
| IConventionEntityTypeBuilder entityTypeBuilder, | ||
| IConventionKey key, | ||
| IConventionContext<IConventionKey> context) | ||
| { | ||
| if (!entityTypeBuilder.Metadata.IsInModel) |
There was a problem hiding this comment.
So is there a general rule for when IsInModel should be used?
There was a problem hiding this comment.
Always, in the OnRemoved conventions. And elsewhere if you are paranoid
There was a problem hiding this comment.
Of course, one won't need to do these checks once we have layering
ajcvickers
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19311
Fixes #20220